[vdk-plugins] vdk-control-api-auth: Add authorization code flow #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doks5
force-pushed
the
person/andonova/vdk-auth
branch
2 times, most recently
from
1f8bc64 to
a62698b
Compare
mivanov1988
reviewed
May 13, 2022
projects/vdk-plugins/vdk-control-api-auth/src/vdk/plugin/control_api_auth/authentication.py
Show resolved
Hide resolved
mivanov1988
approved these changes
May 13, 2022
As part of the ongoing work to build a stand-alone authentication plugin library, which is to be used by all components of Versatile Data Kit that rely on authentication, we need to move and generalize the existing logic from vdk-control-cli. This change introduces the authorization code flow as defined in https://datatracker.ietf.org/doc/html/rfc6749#section-4.1 The implementation of this flow for the purposes of Versatile Data Kit also relies on the use of Proof Key for Code Exchange or pkce. Testing Done: Unit tests. Signed-off-by: Andon Andonov <[email protected]>
doks5
force-pushed
the
person/andonova/vdk-auth
branch
from
a62698b to
ecee32d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the ongoing work to build a stand-alone authentication plugin
library, which is to be used by all components of Versatile Data Kit that
rely on authentication, we need to move and generalize the existing logic
from vdk-control-cli.
This change introduces the authorization code flow as defined in
https://datatracker.ietf.org/doc/html/rfc6749#section-4.1 The implementation
of this flow for the purposes of Versatile Data Kit also relies on the use
of Proof Key for Code Exchange or pkce.
Testing Done: Unit tests.
Signed-off-by: Andon Andonov [email protected]